On 08/04/2010 02:03 PM, Ralf Wildenhues wrote: > Hi Eric, > > * Eric Blake wrote on Wed, Aug 04, 2010 at 09:44:09PM CEST: >> On 08/04/2010 01:08 PM, Ralf Wildenhues wrote: >>> -# We cannot assume aclocal won't warn (aclocal-1.9 does not understand -W* >>> -# options), so check autoconf only. >>> -AT_CHECK([autoconf --force -Wno-syntax], 0, [ignore], [stderr]) >>> +AT_CHECK([autoreconf -v --force -Wno-syntax], 0, [ignore], [stderr]) >> >> Doesn't autoreconf still want to run aclocal under the hood, even if you >> manually touched aclocal.m4? The rest of the patch made sense, but I'm >> not sure about the logic of this hunk. > > No, it shouldn't ever run aclocal in this setting:
See what a bit more research on my part would have done? ;) You're free to push that patch - I agree that testing autoreconf as a whole is better than testing the pieces. -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
