On 08/04/2010 03:04 PM, Bob Friesenhahn wrote: > On Wed, 4 Aug 2010, Ralf Wildenhues wrote: >> >> This is a testsuite bug: it should not trip over a quoting bug in some >> third-party macro file you have installed. OK to fix Autoconf as below? >> >> But please do fix that xmms.m4 file to not have underquoted macros. > > I do see some quoting in the xmms macro but it makes me bleary-eyed and > I hesitate to try fixing it without breaking it. If it really causes > problems, I could simply delete the file.
It is probably doing: AC_DEFINE(XMMS_TEST_VERSION, mess of code) when it should be doing: AC_DEFINE([XMMS_TEST_VERSION], mess of code) In other words, it is likely that the only missing quoting that autoreconf is warning about is that of the first argument - while you are probably right that the rest of the macro is probably not very robust, you can at least rest assured that quoting errors in the rest of the macro will not impact anyone except those who actually use the macro. Only the quoting error on the first argument can affect innocent-bystanders. -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
