> > And second patch we use because of xpg-echo. Would it have sense to have
> > it included, or maybe stop the tests completely instead?
>
> You could just have turned off the xpg_echo option instead of going through
> a convoluted test (which just emulates `shopt -q') to determine whether or
> not it's on, but it does need to be off.
Understood. I'm thinking about it this way - we have nonstandard shell
for historic reasons. Many tests from the test suite still works fine. I
want to test as much as possible of the shell Solaris people will be
using. If I just disable xpg_echo, I won't be testing that. The pain of
maintaining the tests is price for that.
However, if you see point in testing also xpg_echo enabled shell, we
might apply just the changes (echo -E) to where it matters and leave the
rest to be tested in the same way as official shell.
> This demonstrates just how incompatible echo is across shells.
And if you can't trust 'echo' echo, what can you ? :)
Thank you
--
Vlad
