https://sourceware.org/bugzilla/show_bug.cgi?id=20404

            Bug ID: 20404
           Summary: gold/configure --help shall print "
           Product: binutils
           Version: 2.28 (HEAD)
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gold
          Assignee: ccoutant at gmail dot com
          Reporter: dilyan.palauzov at aegee dot org
                CC: ian at airs dot com
  Target Milestone: ---

Provided that gold/configure always turns on "--enable-relro", contrary to
ld/configure, as gold/configure.tgt and ld/configure.tgt differ, gold/configure
--help shall print

--disable-relro    disable -z relro in ELF linker by default

to indicate, that by not specifying anything, relro will be enabled implicitly
in the compiled gold.  Currently gold/configure --help prints "--enable-relro  
     enable -z relro in ELF linker by default" which indicates the opposite.

Please consider adjusting the output of ld.gold --help as follows.

diff --git a/gold/configure.ac b/gold/configure.ac

index de3b630..742af37 100644
--- a/gold/configure.ac
+++ b/gold/configure.ac
@@ -118,8 +118,8 @@ AM_CONDITIONAL(PLUGINS, test "$plugins" = "yes")
 ac_default_ld_z_relro=unset
 # Provide a configure time option to override our default.
 AC_ARG_ENABLE(relro,
-             AS_HELP_STRING([--enable-relro],
-             [enable -z relro in ELF linker by default]),
+             AS_HELP_STRING([--disable-relro],
+             [disable -z relro in ELF linker by default]),
 [case "${enableval}" in
   yes)  ac_default_ld_z_relro=1 ;;
   no)  ac_default_ld_z_relro=0 ;;

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

Reply via email to