https://sourceware.org/bugzilla/show_bug.cgi?id=20882
--- Comment #28 from rguenther at suse dot de --- On Wed, 14 Mar 2018, hjl.tools at gmail dot com wrote: > https://sourceware.org/bugzilla/show_bug.cgi?id=20882 > > --- Comment #27 from H.J. Lu <hjl.tools at gmail dot com> --- > (In reply to rguenther from comment #26) > > On Wed, 14 Mar 2018, hjl.tools at gmail dot com wrote: > > > > > https://sourceware.org/bugzilla/show_bug.cgi?id=20882 > > > > > > --- Comment #25 from H.J. Lu <hjl.tools at gmail dot com> --- > > > (In reply to rguenther from comment #24) > > > > > > > > > > Shouldn't --gc-section tests be enabled in libstdc++ and mark them as > > > > > XFAIL? > > > > > > > > Not sure how reliable we can identify those. Also we'd get > > > > XPASS then unless we have a way to check whether ld is affected by > > > > the bug or not. > > > > > > Any unknown --gc-section test failure should be investigated. If it is > > > > Which is why I reported the bug originally ... > > > > This is exactly the problem. Yes, linker bug was reported, fixed and > verified withe the provided testcase. However, the --gc-section test > in libstdc++ is skipped and I didn't know that the linker fix was incomplete. The test isn't skipped, I _added_ a complete run of the prettyprinter suite with -flto but without --gc-sections. There never were runs of -flto --gc-sections tests. We could add one certainly or run all -flto tests with --gc-sections as the non-lto run does. But that will turn "FAIL"ing tests into UNSUPPORTED, not FAIL, so XFAIL wouldn't work. You'd have to consciously skip the tests that would fail that way and for new "failures" you'll get UNSUPPORTED as well. The tests were supposed to verify the debug info with -flto is now sane enough to have the pretty printers work, not that the ld used works fine with --gc-sections ;) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
