[Bug binutils/26389] nm print "c" for a common symbol with -flto and -fcommon

[amodra at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26389

Alan Modra <amodra at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2020-08-15
           Assignee|unassigned at sourceware dot org   |amodra at gmail dot com
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #1 from Alan Modra <amodra at gmail dot com> ---
Yes, I jumped the wrong way in handling .scommon and other small data common
sections.  I'll commit the following after some testing.

diff --git a/bfd/syms.c b/bfd/syms.c
index b9f73361e6..cb25af17fa 100644
--- a/bfd/syms.c
+++ b/bfd/syms.c
@@ -653,10 +653,10 @@ bfd_decode_symclass (asymbol *symbol)

   if (symbol->section && bfd_is_com_section (symbol->section))
     {
-      if (symbol->section == bfd_com_section_ptr)
-       return 'C';
-      else
+      if (symbol->section->flags & SEC_SMALL_DATA)
        return 'c';
+      else
+       return 'C';
     }
   if (bfd_is_und_section (symbol->section))
     {

-- 
You are receiving this mail because:
You are on the CC list for the bug.