https://sourceware.org/bugzilla/show_bug.cgi?id=29880
Bug ID: 29880
Summary: Out of bound read at `case DST__K_SET_ABS_PC` handler
in function `parse_module`
Product: binutils
Version: 2.40 (HEAD)
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: binutils
Assignee: unassigned at sourceware dot org
Reporter: r3tr0spect2019 at gmail dot com
Target Milestone: ---
Created attachment 14501
--> https://sourceware.org/bugzilla/attachment.cgi?id=14501&action=edit
PoC
# Reproduce
```bash
cd binutils-gdb
git reset --hard f2f58a399cf3f946983398cdfe52d0eaa72bf877
mkdir build && cd build
../configure --disable-gdb --disable-gdbserver --disable-gdbsupport
--disable-libdecnumber --disable-readline --disable-sim --disable-libbacktrace
--disable-gas --disable-ld --disable-werror --enable-targets=all
CPPFLAGS=-DDEBUG CFLAGS="-g -O0 -fsanitize=address"
make all-binutils MAKEINFO=true && true
binutils/addr2line -e poc.bin 0
```
# Output
```
binutils/addr2line: DST__K_RESET_LINUM_INCR not implemented
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 89
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 94
binutils/addr2line: DST__K_SET_PC not implemented
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 81
binutils/addr2line: DST__K_RESET_LINUM_INCR not implemented
binutils/addr2line: DST__K_RESET_LINUM_INCR not implemented
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: DST__K_SET_PC_W not implemented
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 84
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 48
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 32
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 69
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 104
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 28
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 96
binutils/addr2line: DST__K_RESET_LINUM_INCR not implemented
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 83
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 103
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 88
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 68
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 31
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 42
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 100
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 67
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 60
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 73
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 102
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 111
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 100
binutils/addr2line: DST__K_SET_PC_W not implemented
binutils/addr2line: unknown line command 110
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 111
binutils/addr2line: unknown line command 69
binutils/addr2line: unknown line command 72
binutils/addr2line: DST__K_SET_PC_W not implemented
binutils/addr2line: unknown line command 111
binutils/addr2line: unknown line command 80
binutils/addr2line: unknown line command 112
binutils/addr2line: unknown line command 109
binutils/addr2line: unknown line command 81
binutils/addr2line: unknown line command 111
binutils/addr2line: unknown line command 73
binutils/addr2line: unknown line command 108
binutils/addr2line: unknown line command 111
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 111
binutils/addr2line: unknown line command 80
binutils/addr2line: unknown line command 109
binutils/addr2line: unknown line command 111
binutils/addr2line: unknown line command 80
binutils/addr2line: DST__K_SET_LINUM_INCR not implemented
binutils/addr2line: unknown line command 74
binutils/addr2line: unknown line command 48
binutils/addr2line: unknown line command 88
binutils/addr2line: DST__K_SET_PC_W not implemented
binutils/addr2line: unknown line command 109
binutils/addr2line: unknown line command 64
binutils/addr2line: unknown line command 111
binutils/addr2line: unknown line command 73
binutils/addr2line: DST__K_SET_PC_W not implemented
binutils/addr2line: unknown line command 111
binutils/addr2line: unknown line command 73
binutils/addr2line: DST__K_END_STMT_MODE not implemented
binutils/addr2line: unknown line command 111
binutils/addr2line: unknown line command 67
binutils/addr2line: unknown line command 112
binutils/addr2line: unknown line command 56
binutils/addr2line: DST__K_SET_PC_W not implemented
binutils/addr2line: unknown line command 111
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 92
binutils/addr2line: unknown line command 111
binutils/addr2line: unknown line command 73
binutils/addr2line: unknown line command 64
binutils/addr2line: DST__K_END_STMT_MODE not implemented
binutils/addr2line: unknown line command 111
binutils/addr2line: unknown line command 81
=================================================================
==175126==ERROR: AddressSanitizer: heap-buffer-overflow on address
0x61a000000b80 at pc 0x55fe9f360546 bp 0x7ffe25b5d2a0 sp 0x7ffe25b5d290
READ of size 1 at 0x61a000000b80 thread T0
#0 0x55fe9f360545 in bfd_getl32 ../../bfd/libbfd.c:729
#1 0x55fe9f920477 in parse_module ../../bfd/vms-alpha.c:4718
#2 0x55fe9f920fad in module_find_nearest_line ../../bfd/vms-alpha.c:4902
#3 0x55fe9f921911 in _bfd_vms_find_nearest_line ../../bfd/vms-alpha.c:4982
#4 0x55fe9f34db1e in find_address_in_section ../../binutils/addr2line.c:197
#5 0x55fe9f368f43 in bfd_map_over_sections ../../bfd/section.c:1366
#6 0x55fe9f34e8eb in translate_addresses ../../binutils/addr2line.c:337
#7 0x55fe9f34efbc in process_file ../../binutils/addr2line.c:470
#8 0x55fe9f34f5b1 in main ../../binutils/addr2line.c:579
#9 0x7f8e27a30d8f in __libc_start_call_main
../sysdeps/nptl/libc_start_call_main.h:58
#10 0x7f8e27a30e3f in __libc_start_main_impl ../csu/libc-start.c:392
#11 0x55fe9f34d244 in _start
(/binutils-gdb/build/binutils/addr2line+0x343244)
0x61a000000b80 is located 0 bytes to the right of 1280-byte region
[0x61a000000680,0x61a000000b80)
allocated by thread T0 here:
#0 0x7f8e27ce3867 in __interceptor_malloc
../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
#1 0x55fe9f35f8d5 in bfd_malloc ../../bfd/libbfd.c:289
#2 0x55fe9f90a13a in _bfd_malloc_and_read ../../bfd/libbfd.h:970
#3 0x55fe9f920f77 in module_find_nearest_line ../../bfd/vms-alpha.c:4896
#4 0x55fe9f921911 in _bfd_vms_find_nearest_line ../../bfd/vms-alpha.c:4982
#5 0x55fe9f34db1e in find_address_in_section ../../binutils/addr2line.c:197
#6 0x55fe9f368f43 in bfd_map_over_sections ../../bfd/section.c:1366
#7 0x55fe9f34e8eb in translate_addresses ../../binutils/addr2line.c:337
#8 0x55fe9f34efbc in process_file ../../binutils/addr2line.c:470
#9 0x55fe9f34f5b1 in main ../../binutils/addr2line.c:579
#10 0x7f8e27a30d8f in __libc_start_call_main
../sysdeps/nptl/libc_start_call_main.h:58
SUMMARY: AddressSanitizer: heap-buffer-overflow ../../bfd/libbfd.c:729 in
bfd_getl32
Shadow bytes around the buggy address:
0x0c347fff8120: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c347fff8130: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c347fff8140: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c347fff8150: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c347fff8160: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c347fff8170:[fa]fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c347fff8180: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c347fff8190: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c347fff81a0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c347fff81b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c347fff81c0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
Shadow gap: cc
==175126==ABORTING
Aborted (core dumped)
```
# Analysis
`pcl_ptr + DST_S_L_PCLINE_UNSLONG` is accessed without bound check.[1]
[1]
https://github.com/bminor/binutils-gdb/blob/85f9067d3a47d51a46ba369c60fdec752da0f885/bfd/vms-alpha.c#L4718
--
You are receiving this mail because:
You are on the CC list for the bug.
