https://sourceware.org/bugzilla/show_bug.cgi?id=30808
--- Comment #5 from Vladimir Mezentsev <vladimir.mezentsev at oracle dot com> --- On 1/18/24 10:33, hjl.tools at gmail dot com wrote: > https://sourceware.org/bugzilla/show_bug.cgi?id=30808 > > H.J. Lu <hjl.tools at gmail dot com> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > CC| |hjl.tools at gmail dot com > Resolution|FIXED |--- > Status|RESOLVED |REOPENED > > --- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> --- > (In reply to Sourceware Commits from comment #1) >> The master branch has been updated by Vladimir Mezentsev >> <vmeze...@sourceware.org>: >> >> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git; >> h=a13e4c5c10d1a13d9128d033c9525810e876ac14 >> >> commit a13e4c5c10d1a13d9128d033c9525810e876ac14 >> Author: Vladimir Mezentsev <vladimir.mezent...@oracle.com> >> Date: Thu Aug 31 16:26:59 2023 -0700 >> >> Fix 30808 gprofng tests failed >> >> In gprofng testing, we need a tempory gprofng installation to resolve >> run-time >> dependencies on libraries (libgprofng, libopcodes, libbfd, etc). >> We set LD_LIBRARY_PATH and GPROFNG_SYSCONFDIR to find our libraries and >> configuration file. These variables must be set for all gprofng tests. >> >> Tested on aarch64 and x86_64 with and without --enable-shared and >> --target=<>. >> >> gprofng/ChangeLog >> 2023-08-31 Vladimir Mezentsev <vladimir.mezent...@oracle.com> >> >> PR gprofng/30808 >> * testsuite/config/default.exp: Make a temporary install dir. >> Set LD_LIBRARY_PATH, GPROFNG_SYSCONFDIR. >> * testsuite/lib/Makefile.skel: Move LD_LIBRARY_PATH and >> GPROFNG_SYSCONFDIR setting in testsuite/config/default.exp. > This is wrong. You should set up LD_LIBRARY_PATH pointing to the build > directories which contain needed shared libraries. Please see how it is > done in GCC test. > OK. I will try to fix this today. I dislike the binutils testing. The user never uses the configuration we are testing. Why we don't use $prefix in our tests ? We can confugure with --prefix=`pwd`/TMP, run 'make ...' and 'make install' for the development testing. This testing environment will be similar to the one the user will use. What do you think about it ? -Vladimir -- You are receiving this mail because: You are on the CC list for the bug.
