https://sourceware.org/bugzilla/show_bug.cgi?id=33470

--- Comment #19 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Alan Modra from comment #18)
> I have these review comments on the patch.
> 
> Was commit 268533381f80 for people who build libiberty stand-alone?

That is for bootstrap since the plugin file is different for each stage.
I will fix it differently in the v4 patch.

> Otherwise it doesn't seem to be needed, and might be reverted rather than
> applying further changes.  If you do decided to keep the libiberty changes,
> then you should add clang-plugin.m4 to aclocal_deps.
> 
> zlib/configure needs regenerating.
> 
> Otherwise looks good to apply.

I will split it into 3 patches for GCC, binutils and GDB.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Reply via email to