https://sourceware.org/bugzilla/show_bug.cgi?id=34826
Bug ID: 34826
Summary: GNU ld MSP430/MSP430X branch relaxation reads before
section contents
Product: binutils
Version: 2.46
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: ld
Assignee: unassigned at sourceware dot org
Reporter: basavesh.shivakumar at wsu dot edu
Target Milestone: ---
Created attachment 17146
--> https://sourceware.org/bugzilla/attachment.cgi?id=17146&action=edit
repro
I'm reporting this bug on behalf of my team: Ananta Srikar Puranam, Emily West,
Dr. Swarn Priya, Dr. Peng Gao and Dr. Basavesh Ammanaghatta Shivakumar.
Summary
=======
GNU ld --relax on valid MSP430 or MSP430X branch objects with the absolute
relocation at .text+2 reads contents+r_offset-4 without a lower-bound check;
current ASan reports a heap-buffer-overflow READ of size 2 through bfd_getl16
and elf32-msp430.c:2559, two bytes before the section allocation, while the
identical objects link cleanly with --no-relax.
Reproduction
============
1. Download and extract
`bfd-msp430-branch-relax-section-prefix-oob-read-reproducer.tar.gz`.
2. Run the following command with an ld.bfd or all-target `ld-new` binary that
supports the emulation used by the reproducer:
LD=/path/to/ld-new sh repro.sh
The archive contains the fixed input files, independent controls, helper
scripts needed by `repro.sh`, and their checksums. The script uses a temporary
directory and does not modify the source tree.
Observed result
===============
GNU ld --relax on valid MSP430 or MSP430X branch objects with the absolute
relocation at .text+2 reads contents+r_offset-4 without a lower-bound check;
current ASan reports a heap-buffer-overflow READ of size 2 through bfd_getl16
and elf32-msp430.c:2559, two bytes before the section allocation, while the
identical objects link cleanly with --no-relax.
Expected result
===============
GNU ld should either produce the correct output or reject the input with a
normal diagnostic. It should not crash, hang, execute undefined behavior, read
outside an input-derived allocation, or produce the described malformed
output.
--
You are receiving this mail because:
You are on the CC list for the bug.
