On Jul 23, 2007, at 5:18 PM, Jo Rhett wrote:
On Jul 20, 2007, at 5:14 PM, [EMAIL PROTECTED] wrote:This patch fixes the one sent to bug-cfengine by Jo Rhett, which tried to index a enum type (you can't do that), and so it wasn't merged to trunk as it wouldn't compileValid but your change was effectively- Verbose("New action of %s didn't match previous action %s for package %s\n", pkgactions[ptr->action], pkgactions[prev_action], ptr->name ); + Verbose("New action for package %s didn't match previous action \n", ptr->name);The latter is useless. We know that already, I wanted to have verbose output of the status. Better to just drop this line from the patch for now.
I agree. Looks like it was already committed as part of r416, with the line in question commented, on Friday. The commented line can be removed, then.
Index: cfengine-trunk/src/do.c
===================================================================
--- cfengine-trunk.orig/src/do.c
+++ cfengine-trunk/src/do.c
@@ -2801,7 +2801,6 @@ for (ptr = VPKG; ptr != NULL; ptr=ptr->n
/* Process any queued actions (install/remove). */
if ((pending_pkgs != NULL) && ((ptr->action != prev_action) || (ptr->pkgmgr
!= prev_pkgmgr)))
{
- // Verbose("New action of %s didn't match previous action %s for package
%s\n", pkgactions[ptr->action], pkgactions[prev_action], ptr->name );
ProcessPendingPackages(prev_pkgmgr, prev_action, &pending_pkgs);
DeleteItemList( pending_pkgs );
}
-- Eric Searcy OSU Open Source Lab
PGP.sig
Description: This is a digitally signed message part
_______________________________________________ Bug-cfengine mailing list [email protected] https://cfengine.org/mailman/listinfo/bug-cfengine
