-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Michael A Stevens on 5/3/2007 9:44 PM: >> Of the files in your patch, only the changes to ls.c are needed; the >> files >> in man/ and po/ are generated files (either by help2man or by the >> translation project), so patching them directly is not required and only >> makes it harder to see the real patch. Patches should also include a >> ChangeLog entry that summarize the changes, and be generated against the >> development head (CVS or git). > > I was stabbing at the .po files by makeing distclean but the .po files > were still in doc/. After doing a ./configure to rebuild doc/Makefile I > made clean and then rebuilt the docs. I left them in the patch because > they were there on a distclean, perhaps I didn't note the proper clean > target. Is there another target besides distclean that also cleans the > built docs? I'll take note about the Changelog and CVS for anything in > the future.
The easiest way to generate a patch is with 'cvs diff -u' or 'git diff' (depending on whether you did a CVS checkout or cloned the git repository); that automatically ignores all generated files, and shows only the diff of what needs to be applied to version control. Meanwhile, 'make maintainerclean' strips a lot more files (but use with caution, as you need a lot more tools to restore a build after that). >> If this patch is accepted, you would also need to update coreutils.texi >> and NEWS, as well as the testsuite. > > If its actually a worthwhile change to the functionality I'll make sure > to do that. I can't make that call; it is up to Jim as the official maintainer. - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGOq8U84KuGfSFAYARAu6GAJ9TBblrdcXVme9W4MifhfxxejcwhACgkaun OE14NdpVcwFlOCiKSuK7908= =OiOt -----END PGP SIGNATURE----- _______________________________________________ Bug-coreutils mailing list [email protected] http://lists.gnu.org/mailman/listinfo/bug-coreutils
