Hello Jim, a tiny nit again:

Jim Meyering <jim <at> meyering.net> writes:
> +/* A comparison function to sort on increasing inode number.  */
> +static int
> +compare_ino (void const *av, void const *bv)
> +{
> +  struct readdir_data const *const *a = av;
> +  struct readdir_data const *const *b = bv;
> +  return a[0]->ino - b[0]->ino;
> +}

Susceptible to integer overflow, like the gnulib code.

Cheers,
Ralf



_______________________________________________
Bug-coreutils mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/bug-coreutils

Reply via email to