Eric Blake wrote:

> Subject: [PATCH 2/2] build: avoid unused variable warnings on cygwin
>
> -clone_file (int dest_fd, int src_fd)
> +clone_file (int dest_fd ATTRIBUTE_UNUSED, int src_fd ATTRIBUTE_UNUSED)

Minor nit. Would it be better to put "(void) dest_fd; (void) src_fd;"
in the else clause here as those parameters need to be used usually.

cheers,
Pádraig.



Reply via email to