Pádraig Brady <P <at> draigBrady.com> writes: > > -clone_file (int dest_fd, int src_fd) > > +clone_file (int dest_fd ATTRIBUTE_UNUSED, int src_fd ATTRIBUTE_UNUSED) > > Minor nit. Would it be better to put "(void) dest_fd; (void) src_fd;" > in the else clause here as those parameters need to be used usually.
Using ATTRIBUTE_UNUSED implies 'might be unused', not 'never used'. But yes, for unused parameters, I like the idea of (void) dest_fd in the function body rather than ATTRIBUTE_UNUSED in the function declaration in cases where we know that some compilation paths use it. I'll adjust my patch accordingly. -- Eric Blake
