Pádraig Brady wrote: > The attached patch removes the inconsistent use of bitwise > operators on boolean values. > > As well as being distracting, bitwise operators are > not short circuiting and brittle with C89 where > bool can be an int, i.e. > 1. ... > Subject: [PATCH] maint: Use logical rather than bitwise operators on bools > > This is because bitwise operators are: > - distracting and inconsistent in a boolean context > - non short circuiting > - brittle in C89 where bool can be an int (so > 1)
Good change. That looks fine and passes "make check". Thanks!
