This solution makes sense to me.  I think my argument is probably strenthened
by the fact that 'cvs tag -d <<TAG>>' in a directory doesn't remove the tag
from removed files.

Thanks!

Dave

On Tue, Feb 22, 2000 at 08:52:41AM +1300, Chris Cameron wrote:
> On Saturday, February 19, 2000 5:41 AM, Greg A. Woods 
> [SMTP:[EMAIL PROTECTED]] wrote:
> > [ On Friday, February 18, 2000 at 17:58:35 (+1300), Chris Cameron wrote: 
> ]
> > > Is this a bug?  A tag -F will move an existing tag, maybe it should 
> check
> > > in the Attic and remove the tag from any files which contain the tag?
> >
> > That's a good idea!  I.e. if the tag exists (on the current branch?) in a
> > removed file (i.e. removed on the current branch), then the tag sould be
> > removed too if the tag would be moved to the head.  That does mean not
> > removing the tag unless either '-f' was specified or a removed file was
> > explicitly specified on the command-line.
> >
> > This fix might even be a sufficient solution to Dave's problem too!
> >
>  I'd like to propose that the behaviour be implemented only for a move or 
> delete of a tag WHERE files are not specified (i.e. cvs tag -d or cvs tag 
> -f NOT on cvs tag -f file.c).  In these cases, the tag operation should 
> check through the Attic for any files containing the specified tag and 
> remove it.  My argument for doing this is that if you are moving a tag, or 
> deleting a tag, any files which have been removed from the current 
> directory should have the tag removed, otherwise it is not possible to do a 
> cvs co -r xxx yyy and get exactly what you tagged as you could get some 
> Attic files as well.
> 
> Any feedback would be appreciated, otherwise I'll start looking at the code 
> involved.
> 
> 
> ***************************************************************
> Chris Cameron                    Open Telecommunications NZ Ltd
> Software Development Team Leader
> [EMAIL PROTECTED]                           P.O.Box 10-388
>       +64 4 495 8403 (DDI)                          The Terrace
> fax:  +64 4 495 8419                                 Wellington
> cell: +64 21 650 680                                New Zealand
> Life, don't talk to me about life ....(Marvin - HHGTTG)
> 
> 

-- 
David Copeland
Software Engineering Director
NOVO
Relationship Architects for e-Business

Voice 415 646 7026 | Fax 415 646 7001
http://www.novocorp.com

Reply via email to