Follow-up Comment #10, bug #17560 (project cvs):
I have made a few changes in the code from the
rcs.diff.3 patch:
+ Avoid C99/C++ "//" style comments.
Use C89 "/* ... */" style comments.
+ Use white space to separate operators.
+ Put curly braces on their own lines.
+ Use xnmalloc (qty, size) instead of
xnrealloc (NULL, qty, size)
+ Do not mix 'int' and and 'unsigned long' in comparisons.
It appears that the linevector_delete function is
no longer used. Should it be deleted?
I have started a 'make check on this revised patch.
If all goes well, I'll hope to commit tomorrow.
What attribution do you wish for the patch?
Maybe <[EMAIL PROTECTED]> would be okay?
_______________________________________________________
Additional Item Attachment:
File name: rcs.c.patch Size:5 KB
Revised patch that conforms better to the CVS standards.
<http://savannah.nongnu.org/bugs/download.php?file_id=10697>
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/bugs/?17560>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/
_______________________________________________
Bug-cvs mailing list
[email protected]
http://lists.nongnu.org/mailman/listinfo/bug-cvs
