-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Paolo Bonzini on 8/20/2009 2:27 AM: > While the discussion proceeds, what about this very tiny preliminary > step? > > Paolo > > 2009-08-20 Paolo Bonzini <[email protected]> > > * lib/cloexec.c: Do not define FD_CLOEXEC here. > * lib/popen-safer.c: Do not alias O_NOINHERIT to O_CLOEXEC here. > * lib/fcntl.in.h: Do both things here.
Sounds okay to me. > > +/* Fix up the FD_* macros. */ > + > +#ifndef FD_CLOEXEC > +# define FD_CLOEXEC 1 > +#endif Is mingw the only known platform that lacks this? I'm worried that if any other platform has F_GETFD but not FD_CLOEXEC, that we could be conflicting with some other FD_* bit reserved by the application (but it is a very marginal worry; I suspect that we are safe because this only triggers for mingw, where providing this replacement hardcoded to 1 makes no difference since we will also be the ones implementing F_GETFD). - -- Don't work too hard, make some time for fun as well! Eric Blake [email protected] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkqN2DUACgkQ84KuGfSFAYB8VwCcCsYevftnIiN6m3iaFZwAoNf+ 4oEAoKfsnJoDH8/P3IyQIY715daEHrgY =ciKr -----END PGP SIGNATURE-----
