Hi Bruno,
thanks for these patches. I've left some comments below. > [PATCH 6/6] gnulib-tool.py: follow gnulib-tool changes, part 14 > gnulib-tool: don't transform binary files with sed All these sed transformers shall be IMHO entirely deprecated. I don't quite remember why I used sed; may be I could not find a way to express the same idea using Python "re" module. Anyway, feel free to push it, because right now it will make the behavior more stable; be aware though that this part of code is going to be removed. > [PATCH 5/6] gnulib-tool.py: follow gnulib-tool changes, part 13 > gnulib-tool: concatenate lib_SOURCES to a single line A bit tricky one, but OK from my side. The only thing I noted is that `startpos,pos = match.span()` can be a bit better formatted into `(startpos, pos) = match.span()`. Everything is OK though, feel free to push. 2017-09-09 17:52 GMT+03:00 Bruno Haible <[email protected]>: > Hi Dmitry, > > Here's the next round of patches, for your review. I'm slowly working > through > the past gnulib-tool changes. > > Bruno > > -- With best regards, Dmitry Selyutin
