Hi Bruno, Bruno Haible <[email protected]> writes:
> A small nit in the first of these patches, though: > > + [case "$host_os" in > + # Guess yes on glibc systems. > + *-gnu* | gnu*) gl_cv_glob_overflows_stack="guessing yes" ;; > + esac > + ]) > > When cross-compiling, gl_cv_glob_overflows_stack ought to be assigned > in all cases. In other words, the 'case' statement is lacking a default > clause at the end. Such as: > > # If we don't know, obey --enable-cross-guesses. > *) gl_cv_glob_overflows_stack="$gl_cross_guess_inverted" ;; Ah, I see. Thanks. Pushed the attached patch. Collin
>From 0acb69c4e0c2f584b16ee351e64fd181c93663cf Mon Sep 17 00:00:00 2001 Message-ID: <0acb69c4e0c2f584b16ee351e64fd181c93663cf.1760490710.git.collin.fu...@gmail.com> From: Collin Funk <[email protected]> Date: Tue, 14 Oct 2025 18:10:48 -0700 Subject: [PATCH] glob: Ensure --enable-cross-guesses is obeyed (regr. yesterday). Reported by Bruno Haible in <https://lists.gnu.org/archive/html/bug-gnulib/2025-10/msg00041.html>. * m4/glob.m4 (gl_GLOB): Set gl_cv_glob_overflows_stack on platforms other than glibc. --- ChangeLog | 8 ++++++++ m4/glob.m4 | 4 +++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 9ab4c4040a..c3dd9cbb7f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2025-10-14 Collin Funk <[email protected]> + + glob: Ensure --enable-cross-guesses is obeyed (regr. yesterday). + Reported by Bruno Haible in + <https://lists.gnu.org/archive/html/bug-gnulib/2025-10/msg00041.html>. + * m4/glob.m4 (gl_GLOB): Set gl_cv_glob_overflows_stack on platforms + other than glibc. + 2025-10-13 Collin Funk <[email protected]> glob tests: Add a test for the glibc bug. diff --git a/m4/glob.m4 b/m4/glob.m4 index 563e8e4ff8..6f086f78c2 100644 --- a/m4/glob.m4 +++ b/m4/glob.m4 @@ -1,5 +1,5 @@ # glob.m4 -# serial 31 +# serial 32 dnl Copyright (C) 2005-2007, 2009-2025 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -54,6 +54,8 @@ AC_DEFUN([gl_GLOB] [case "$host_os" in # Guess yes on glibc systems. *-gnu* | gnu*) gl_cv_glob_overflows_stack="guessing yes" ;; + # If we don't know, obey --enable-cross-guesses. + *) gl_cv_glob_overflows_stack="$gl_cross_guess_inverted" ;; esac ]) ]) -- 2.51.0
