Collin Funk wrote: > @@ -86,7 +86,7 @@ @node Setting the package version > dist-hook: dist-tarball-version > .PHONY: dist-tarball-version > dist-tarball-version: > - echo '$(VERSION)' > $(distdir)/.tarball-version > + $(AM_V_GEN)echo '$(VERSION)' > $(distdir)/.tarball-version > @end example > > Typically, the maintainer will set the version number in a clean directory
This patch is not good. 1) It makes no sense to use $(AM_V_GEN) in a phony rule, because the output pretends to "GEN"erate $@. But there is no file named 'dist-tarball-version'. 2) It is actually useful for the maintainer to know what value is stored in .tarball-version. When the maintainer is making a release, he certainly does not want to have an unexpected value in this important place. Therefore here it is very useful — more useful than elsewhere — to see the full command. Bruno
