Am Do., 15. Jan. 2026 um 05:54 Uhr schrieb Collin Funk <[email protected]>: > > Bruno Haible <[email protected]> writes: > > > Collin Funk wrote: > >> @@ -86,7 +86,7 @@ @node Setting the package version > >> dist-hook: dist-tarball-version > >> .PHONY: dist-tarball-version > >> dist-tarball-version: > >> - echo '$(VERSION)' > $(distdir)/.tarball-version > >> + $(AM_V_GEN)echo '$(VERSION)' > $(distdir)/.tarball-version > >> @end example > >> > >> Typically, the maintainer will set the version number in a clean directory > > > > This patch is not good. > > > > 1) It makes no sense to use $(AM_V_GEN) in a phony rule, because the output > > pretends to "GEN"erate $@. But there is no file named > > 'dist-tarball-version'. > > True. > > > 2) It is actually useful for the maintainer to know what value is stored in > > .tarball-version. When the maintainer is making a release, he certainly > > does not want to have an unexpected value in this important place. > > Therefore > > here it is very useful — more useful than elsewhere — to see the full > > command. > > Well, the file contents should be the same as the version suffix in the > tarball, no? Automake uses "$(PACKAGE)-$(VERSION)" for the distdir and > adds the archive suffix to the end, using the values from AC_INIT. The > same $(VERSION) is placed in .tarball-version. > > Regardless, we can leave it as is. Some slightly noisy text on my > terminal is less bad than you missing an error in a release tarball, of > course. :)
I think you can have both. $(AM_V_AT)echo '$(VERSION)' > $(distdir)/.tarball-version @if ! $(AM_V_P); then echo ' VERSION $(VERSION)' ; fi Or: $(AM_V_AT)echo '$(VERSION)' > $(distdir)/.tarball-version @if ! $(AM_V_P); then echo ' GEN .tarball-version [version $(VERSION)]' ; fi Marc
