The new sc_unsigned_{char,short,int,long} checks were throwing false
positives on their own commentary. Fix attached.
This is the third (and last) problem with maint.mk that I tripped over
by simply copying the file into the Autoconf tree and then running
"make syntax-check". I don't mean to be That Guy, but it seems like
whoever wrote these changes can't have tested them *at all*. :-(
zw
From 432a448af5a2197244981a6efa992fc31b5e2215 Mon Sep 17 00:00:00 2001
From: Zack Weinberg <[email protected]>
Date: Tue, 3 Feb 2026 11:34:15 -0500
Subject: [PATCH] syntax-check: avoid unsigned_* false positive on maint.mk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* maint.mk (sc_unsigned_char, sc_unsigned_short, sc_unsigned_int)
(sc_unsigned_log): Add âexcludeâ patterns so that these tests do
not throw a false positive on their own commentary.
---
maint.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/maint.mk b/maint.mk
index 1fa112df..94fd4cca 100644
--- a/maint.mk
+++ b/maint.mk
@@ -879,18 +879,22 @@ sc_obsolete_symbols:
# Prohibit BSD4.3/SysV u_char, u_short, u_int and u_long usage.
sc_unsigned_char:
@prohibit=u''_char \
+ exclude='Prohibit BSD4\.3/SysV u_' \
halt='don'\''t use u''_char; instead use unsigned char' \
$(_sc_search_regexp)
sc_unsigned_short:
@prohibit=u''_short \
+ exclude='Prohibit BSD4\.3/SysV u_' \
halt='don'\''t use u''_short; instead use unsigned short' \
$(_sc_search_regexp)
sc_unsigned_int:
@prohibit=u''_int \
+ exclude='Prohibit BSD4\.3/SysV u_' \
halt='don'\''t use u''_int; instead use unsigned int' \
$(_sc_search_regexp)
sc_unsigned_long:
@prohibit=u''_long \
+ exclude='Prohibit BSD4\.3/SysV u_' \
halt='don'\''t use u''_long; instead use unsigned long' \
$(_sc_search_regexp)
--
2.52.0
