"Zack Weinberg" <[email protected]> writes: > On Tue, Feb 3, 2026, at 12:26 PM, Bruno Haible wrote: >> Zack Weinberg wrote: >>> I suggest that in the future >>> `make syntax-check` should be part of the tests for updates to >>> maint.mk within Gnulib. >> >> I don't think this is adequate. maint.mk is, by design, meant for packages >> that _use_ Gnulib. Gnulib itself has its own set of syntax-check rules, >> defined in gnulib/Makefile. I don't think it would be wise to conflate >> one with the other. > > The specific thing I am asking for, is for you to run maint.mk's syntax checks > *on maint.mk itself*, whenever those syntax checks are updated, to prevent > future problems like the ones I just tripped over. How that is accomplished > within Gnulib is up to you.
That idea sounds reasonable to me. But projects can define their own syntax-checks in cfg.mk, which have stricter rules on something like formatting than maint.mk does. I guess an idea is copying maint.mk into a temporary directory, setting up a dummy git repository so 'vc-list-files' returns only maint.mk, and then running 'make -f syntax-check'. I haven't tested that, but it makes sense in my head. :) Collin
