On 09/02/2026 22:08, Collin Funk wrote:
Arun Giridhar <[email protected]> writes:Hello, I would like to request a documentation addition to `--with-openssl`: ``` diff --git a/m4/gl-openssl.m4 b/m4/gl-openssl.m4 index 70f43a5582..f75f52c324 100644 --- a/m4/gl-openssl.m4 +++ b/m4/gl-openssl.m4 @@ -24,8 +24,8 @@ AC_DEFUN([gl_CRYPTO_CHECK], [[ --with-openssl[=ARG] use libcrypto hash routines for the hash functions MD5, SHA-1, SHA-224, SHA-256, SHA-384, SHA-512. Valid ARGs are: - 'yes', - 'no', + 'yes' ==> use external openssl library, + 'no' ==> use gnulib version instead of openssl, 'auto' => use if any version available, 'auto-gpl-compat' => use if GPL compatible version available, ``` This is to prevent confusion over the implications of the options "yes" and "no". In particular, "no" should make clear that those hash functions are still available but will use the gnulib version instead of the external openssl version, so it's only a difference in performance (maybe) not functionality. This was motivated by this discussion in GNU Octave here: https://octave.discourse.group/t/7311 If you accept this change, I do not seek to be named for it.That seems like a good idea to me. I'll double check the output of './configure --help' later and can commit it under your name.
Let's refrain from using "openssl" as there are other libcrypto implementations. But fair enough on expanding the descriptions. I'd use: 'yes' ==> use external libcrypto 'no' ==> use gnulib fallback implementation That implies functionality is equivalent, but the external is generally preferred (for speed/standard conformance/...) cheers, Padraig
