Arun Giridhar <[email protected]> writes: > @Pádraig: > >> Let's refrain from using "openssl" as there are other libcrypto > implementations. > > The configure option itself is currently "--with-openssl". Will you be > changing that to something else like e.g. "--with-libcrypto"? (I am OK > either way.)
I don't think that change is needed. It will just give other GNU maintainers and packagers more work to replace the option. The other libcrypto implementations (e.g. LibreSSL, BoringSSL, AWS-LC, etc.) are all forks of OpenSSL. So they will have similar APIs to OpenSSL. I assume the small set we use are unchanged, but I have not looked. Anyways, I pushed the attached patch with Pádraig's suggested wording. > @Collin: > >> I'll double check the output of './configure --help' later and can >> commit it under your name. > > I don't need to be named for this documentation request, but if you > need to do so for internal tracking, please use my Savannah identity / > email: https://savannah.gnu.org/users/arungiridhar Not really needed for internal tracking, and it is a small patch so it is not significant for purposes of copyright. I just don't want to take credit for other peoples work. :) I pushed it in my name, since it seems that is you preference. Thanks for the report! Collin
>From 5457e839e4b235c97341829a358e373e7ab3ae81 Mon Sep 17 00:00:00 2001 Message-ID: <5457e839e4b235c97341829a358e373e7ab3ae81.1770694504.git.collin.fu...@gmail.com> From: Collin Funk <[email protected]> Date: Mon, 9 Feb 2026 19:25:41 -0800 Subject: [PATCH] crypto/{sha*,md5}-buffer: Improve ./configure --help output. * m4/gl-openssl.m4 (gl_CRYPTO_CHECK): Mention that --with-openssl=yes will use libcrypto and --with-openssl=no will use a fallback implementation provided by gnulib. --- ChangeLog | 7 +++++++ m4/gl-openssl.m4 | 6 +++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 9415ff0bf2..5fa1787fa6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2026-02-09 Collin Funk <[email protected]> + + crypto/{sha*,md5}-buffer: Improve ./configure --help output. + * m4/gl-openssl.m4 (gl_CRYPTO_CHECK): Mention that --with-openssl=yes + will use libcrypto and --with-openssl=no will use a fallback + implementation provided by gnulib. + 2026-02-09 Bruno Haible <[email protected]> signbit: Fix compil. error in C++ mode on macOS 14 (regr. 2026-02-03). diff --git a/m4/gl-openssl.m4 b/m4/gl-openssl.m4 index 70f43a5582..4ea93465fa 100644 --- a/m4/gl-openssl.m4 +++ b/m4/gl-openssl.m4 @@ -1,5 +1,5 @@ # gl-openssl.m4 -# serial 8 +# serial 9 dnl Copyright (C) 2013-2026 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -24,8 +24,8 @@ AC_DEFUN([gl_CRYPTO_CHECK] [[ --with-openssl[=ARG] use libcrypto hash routines for the hash functions MD5, SHA-1, SHA-224, SHA-256, SHA-384, SHA-512. Valid ARGs are: - 'yes', - 'no', + 'yes' => use external libcrypto, + 'no' => use gnulib fallback implementation, 'auto' => use if any version available, 'auto-gpl-compat' => use if GPL compatible version available, -- 2.53.0
