Paul Eggert wrote:
> > + ((value << (count & (sizeof value * 8 - 1))) \
> > + | (value >> ((-count) & (sizeof value * 8 - 1))))
> > +# endif
>
> 8 * sizeof (something) is easier to read than sizeof (something) * 8.
Although it's only a question of style, I disagree here. The common way
of noting multiplications is
total number of X = number of elements * number of X per element
For instance,
- the number of minutes in a day is 24 * 60 [1],
- the number of bytes in an N-element array is N * sizeof(element),
[2][3]
Therefore I find Collin's style perfectly fine.
Bruno
[1] lib/parse-datetime.y
[2] ISO C 23 ยง 7.24.3.2.(3)
[3] lib/size.h line 114
