Collin Funk wrote:
> I've attached patches adding the stdc_rotate_{left,right} macros and
> functions, but have not pushed them yet.Re 0001: > +# define __gl_stdc_rotate_left __builtin_stdc_rotate_left Please don't use identifiers that start with '__gl'. Identifiers that start with '__' belong to the system (= compiler + libc). At most one leading underscore is OK, though. > GL_STDC_ROTATE_LEFT=1 This should be replaced with a module indicator macro: gl_STDBIT_MODULE_INDICATOR([stdc_rotate_left]) and you need to define the gl_STDBIT_MODULE_INDICATOR macro in m4/stdbit_h.m4. Look at the idioms for e.g. stdlib.h. Re 0003: > +# define __gl_stdc_rotate_right __builtin_stdc_rotate_right > +GL_STDC_ROTATE_RIGHT=1 Likewise. Thanks also for providing good unit tests! Bruno
