On 26 January 2011 17:53, Jim Meyering <[email protected]> wrote: > >> One comment about the documentation: grep.texi has different >> sectioning for the flags from grep --help; perhaps this should be >> fixed? > > If you think one is obviously better than the other, > please explain why along with a patch to improve things.
I don't have an opinion on which is better, just that they should be consistent. > I applied your patch and got a warning from git am about trailing spaces. I have now set up whitespace-mode to know about grep (other GNU projects seem to use tabs), so should avoid that in future. > An attempt to build (configure with --enable-gcc-warnings) failed Thanks for that tip, I was wondering why I wasn't getting warnings. > I've attached the incremental, followed by full format-patch output, > with that merged in. Please apply that to a clean check-out > (via git am) Apologies in advance if I've done something dumb, but I can't get this to work. I saved your email, removed the top so I had just the full format-patch patch (otherwise, git am complained about non-existent files such as zio.c, which made sense since I was applying the patch to a clean checkout), and then I ran git am, and got: Applying: grep: add --decompress flag for transparent decompression error: patch failed: tests/Makefile.am:104 error: tests/Makefile.am: patch does not apply This appears to be a whitespace issue and nothing to do with the patch proper. If I simply remove that section of the patch, it does apply. I will reply separately about pipes and a bz2 test. -- http://rrt.sc3d.org
