On 12/10/2011 08:40 PM, Paul Eggert wrote:
the patches are okay with me, but they will only have an effect
as long as distributors use --with-included-regex
In that case, they should be combined with --with-included-regex, or
with a test that checks that regular expression handling is rational
in the system regex code.
But you can't do that as long as --with-included-regex breaks [[=a=] and
[[.a.]].
BTW, I reviewed the patch again and the hunk changing regexec is also
wrong. If the range handling in system regex code is sane, it will be a
nop. If it is not, it will cause unwanted mismatches between two
regexes that are similar except one uses backreferences and the other
doesn't.
So, the gnulib changes are fine, but not the grep changes. I'll look at
them next week.
Paolo
