On 12/11/2011 12:24 PM, [email protected] wrote:
> BTW, I reviewed the patch again and the hunk changing regexec is also
> wrong.
There were no changes to regexec, only in regcomp. Similar in dfa.c.
I meant the hunk removing the regexec calls in dfa.c. It can stay, so
the patch you sent for match_mb_charset should be all that's needed for
dfa.c. I don't have a testcase because usually dfa.c punts and calls
the glibc when it finds a multi-byte bracket.
For regex, you should likewise look for wcscoll in regexec.c and fix it.
Here, the testcase should be that for example [d-f] should not match "รจ".
Paolo
