Update of bug #67570 (group groff):

                 Summary: [troff] `cflags` request ignored when used on a
class since commit 77d8f728d, 2025-09-04 => [troff] `cflags` request ignored
when used on a class

    _______________________________________________________

Follow-up Comment #14:

I posted an update to the wrong ticket yesterday.  It went to bug #52433 when
it should have gone here.  Here 'tis.

----

Bisecting the Japanese code points thing was not fruitful.

So I went back to what I could (and should) have done after comment #0, and
bisected using your exhibit and a starting point of `pchar`'s birth in March,
which was early enough.


    $ git bisect good
    77d8f728dba1c483b2fbbbe64017c0668c5b8450 is the first bad commit
    commit 77d8f728dba1c483b2fbbbe64017c0668c5b8450
    Author: G. Branden Robinson <[email protected]>
    Date:   Thu Sep 4 01:39:31 2025 -0500

        [troff]: Trivially refactor.

        Rename `charinfo` class's member function `get_unicode_code()` to
        `get_unicode_mapping()`.

        * src/roff/troff/charinfo.h (class charinfo): Do it.

        * src/roff/troff/input.cpp (charinfo::get_unicode_code): Rename
this...
          (charinfo::get_unicode_mapping): ...to this.

          (define_class, charinfo::get_flags): Update call sites.

     ChangeLog                 | 11 +++++++++++
     src/roff/troff/charinfo.h |  2 +-
     src/roff/troff/input.cpp  | 12 ++++++------
     3 files changed, 18 insertions(+), 7 deletions(-)


Another trivial refactoring bites me in the butt.

Ingo will laugh at me, but it'll be worth it if I get a regression test out of
this.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?67570>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

Attachment: signature.asc
Description: PGP signature

Reply via email to