Follow-up Comment #3, bug #67916 (group groff): At 2026-01-17T12:53:21-0500, Deri James wrote: > Follow-up Comment #2, bug #67916 (group groff): > > A good idea. This is the change I will be pushing.
Looks good to me!
There's some commented-out stuff in the _gropdf_ man page I can take
care of after you land this.
(another remark and question lie below)
> diff --git a/tmac/pdf.tmac b/tmac/pdf.tmac
> index 658ba17d3..f2e1c9d62 100644
> --- a/tmac/pdf.tmac
> +++ b/tmac/pdf.tmac
> @@ -718,9 +718,14 @@ with '-A' option
> . \}
> . el \{\
> . ds PDFHREF.DESC Unknown
> -. pdf:lookup \\*[pdf:href-D]
> -. if !'\\*[pdf:lookup-result]'' .ds PDFHREF.DESC \\*[pdf:lookup-value]
> +. ie '\\*[pdf*href.class]'W' \{\
> +. if !'\\*[pdf:href-D]'' .ds PDFHREF.DESC \\*[pdf:href-D]
> . \}
> +. el \{\
> +. pdf:lookup \\*[pdf:href-D]
> +. if !'\\*[pdf:lookup-result]'' .ds PDFHREF.DESC
> \\*[pdf:lookup-value]
> +. \}
> +. \}
> . \" Apply border and colour specifications to the PDFMARK string
> . \" definition, as required.
> . \"
>
> Here's another test for pdfhref L.
>
> [derij@pip build (master)]$ cat pdfhref_l.trf
> .sp
> I'm a raw
> \fIgroff\fP
> document.
> .sp
> .nf
> .pdfbookmark -T bm:2 1 Start
> \fBStart\fP
> Jump to \c
> .pdfhref L -D bm:1 -A .
> .sp 6i
> .pdfbookmark -T bm:1 1 End
> \fBEnd\fP
> Now jump to \c
> .pdfhref L -D bm:2 -A .
>
> Run it with both these commands:-
>
> ./test-groff -Tpdf pdfhref_l.trf | okular -
> ./test-pdfmom --roff pdfhref_l.trf | okular -
>
> The first command has a forward reference which is satisfied by using
> pdfmom --roff.
Yup. But it should be possible to write a regression-test for this
without involving forward references. Would you like me to do that?
(Don't gate your push on it; I can add the test subsequently.)
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?67916>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
signature.asc
Description: PGP signature
