From: "Ashutosh S. Rajekar" <[EMAIL PROTECTED]>
Subject: Re: some changes to stage2/char_io.c
Date: Fri, 13 Aug 1999 01:01:59 -0500 (GMT)

>       Attached is the unified diff patch. I can't access the ChangeLog
> file, due to the wierd Internet software I have to use, so I am including
> the diff'ed ChangeLog file also as an attachment.

  Your patch seems to be still awkward... there are many many empty
lines. I had to see it via a simple filter.

  Now for more essetial thing: What is the benefit of your patch? I
don't see any reason. Some code in your patch even increases the size
of stage2.

  Note: every GNU programmer should read the GNU Coding Standards. I
often receive patches that do not conform to the standards, which
consumes my time and my energy. Especially, the section "Change Logs"
is very important.

----------------------------------------------------------------------
OKUJI Yoshinori  <[EMAIL PROTECTED]>           ^o-o^
http://duff.kuicr.kyoto-u.ac.jp/~okuji (in English)     m /

Reply via email to