Am Freitag, 21. Dezember 2012 schrieb Nikita Karetnikov: > 1. Change 'uri' according to this [1] example.
What does this change? Especially as it is not done systematically for the files already in the distribution. > 2. Use a single semicolon after expression. [2] Okay, thanks. > 3. It's probably better to say what licenses are used for the other > files. Actually, what is one expected to do concerning licenses? README says: "Rsync may be used, modified and redistributed only under the terms of the GNU General Public License, found in the file COPYING in this distribution" COPYING is GPLv3. So I checked a few files whether this means gpl3 or gpl3+. rsync.c states gpl3+, for example. Some other files have different license statements. There is a subdirectory popt containing a different COPYING (looks like X11 license). The file snprintf.c in the subdirectory lib has: /* * Copyright Patrick Powell 1995 * This code is based on code written by Patrick Powell ([email protected]) * It may be used for any purpose as long as this notice remains intact * on all source code distributions */ There may potentially be as many licenses as files in the distribution (208), that is why I went with only the main statement from the README file. What would good practice be? Andreas
