Hello, I reviewed your patch, and three points caught my attention:
- You used CMOCKA_FLAGS in tests/Makefile.am. Shouldn't this be CMOCKA_CFLAGS? - The cmocka dependency appears to be mandatory in the current patch. Do you plan to make it optional for users who only want to build the translator without running tests, or is there another reason for this choice? - You haven't included the full output of the count != 0 error. In particular, how did you verify that __wrap_gethostbyname() is actually being called? Since each test has one will_return() and the wrapper consumes one value through mock(), I suggest checking the linker wrapping first. Have you checked this? Finally, your GitHub profile lists Red Hat. I couldn't independently verify this online; what is your connection to Red Hat? Best regards, Alperen On Wed, Nov 4, 2026 at 6:40 PM Gianluca Cannata <[email protected]> wrote: > This patch introduces the initial unit testing infrastructure under > the tests/ directory for httpfs, focusing on validating lookup_host > success and failure handling. > > You can find the source code here: > https://github.com/aculnaig/httpfs/tree/cvs > > The patch is attached to this email. > > Best regards, > > Gianluca >
