Il giorno mer 4 nov 2026 alle ore 17:53 Alperen Erkan <[email protected]> ha scritto: > > Hello,
Hello Alperen, > I reviewed your patch, and three points caught my attention: > > - You used CMOCKA_FLAGS in tests/Makefile.am. Shouldn't this be > CMOCKA_CFLAGS? Thank you, it was a typo. > - The cmocka dependency appears to be mandatory in the current patch. Do > you plan to make > it optional for users who only want to build the translator without running > tests, or is there another > reason for this choice? I plan to add it as an optional dependency, yes. I simplified a little bit for now for the sake of simplicity. > - You haven't included the full output of the count != 0 error. In > particular, how did you verify that > __wrap_gethostbyname() is actually being called? Since each test has one > will_return() and the > wrapper consumes one value through mock(), I suggest checking the linker > wrapping first. Have > you checked this? The only output I get is this when I run make check: ====================================== httpfs 0.1: tests/test-suite.log ====================================== # TOTAL: 1 # PASS: 0 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 System information (uname -a): GNU 0.9 GNU-Mach 1.8+git20260805-up-486/Hurd-0.9 i686-AT386 Distribution information (/etc/os-release): PRETTY_NAME="Debian GNU/Hurd forky/sid" NAME="Debian GNU/Hurd" VERSION_CODENAME=forky ID=debian HOME_URL="https://www.debian.org/"; SUPPORT_URL="https://www.debian.org/support"; BUG_REPORT_URL="https://bugs.debian.org/"; .. contents:: :depth: 2 FAIL: test_httpfs ================= [==========] tests: Running 2 test(s). [ RUN ] test_lookup_host_1 [ ERROR ] --- count != 0 [ LINE ] --- ./src/cmocka.c:1073: error: Failure! [ FAILED ] test_lookup_host_1 [ RUN ] test_lookup_host_2 [ ERROR ] --- count != 0 [ LINE ] --- ./src/cmocka.c:1073: error: Failure! [ FAILED ] test_lookup_host_2 [==========] tests: 2 test(s) run. [ PASSED ] 0 test(s). [ FAILED ] tests: 2 test(s), listed below: [ FAILED ] test_lookup_host_1 [ FAILED ] test_lookup_host_2 2 FAILED TEST(S) FAIL test_httpfs (exit status: 2) > Finally, your GitHub profile lists Red Hat. I couldn't independently verify > this online; what is your connection to Red Hat? I contribute to the Hurd as a free person in my spare time whenever possible and outside working hours, if you want to know that. May I ask what is your concern ? Gianluca > Best regards, > Alperen
