Thomas Klausner <[email protected]> writes: > Hi James! > > On Sat, Nov 09, 2013 at 09:39:34PM +0100, Joerg Sonnenberger wrote: >> On Sat, Nov 09, 2013 at 12:20:36PM +0000, James wrote: >> > These patches don't apply cleanly to current master. >> > >> > If you can git format them, then I can shepherd them through our >> > patch review/test process for you. >> >> Not easily and I don't have time for adopting them to a git checkout. >> Maybe Thomas has... > > Thanks for the offer! > > I've adapted the patches to apply to lilypond git (from yesterday). > There are two of them:
I'm not sure you've seen the issue in the tracker: <URL:http://code.google.com/p/lilypond/issues/detail?id=3656>. It should cover the std-vector.hh part. > The other patch removes ambiguity with respect to to_string. Can you think of a reasonably nice way to have this ambiguity not occur in that manner? The way your patch resolves the problem at the call points may be the simplest way to resolve it, but would likely lead to having the problem reintroduced inadvertantly repeatedly by people working with g++ and submitting new patches. For a rarely used platform like clang++, the net result of this fix would likely be that we get to hear something like "oh, by the way, the last three versions did not compile using clang++ so I used GCC instead" occasionally. Or not hear it at all. So a fix that does not make it as easy to trigger the problem when doing straightforward coding would be preferable. -- David Kastrup _______________________________________________ bug-lilypond mailing list [email protected] https://lists.gnu.org/mailman/listinfo/bug-lilypond
