On 2/5/25 11:56 AM, Bruno Haible wrote: > Hi Eli, > >> it seems like these Haiku issues are the main blocker >> now. Do you happen to know / would be able to test whether these test >> failures on Haiku also manifest with the testsuite on Patch v2.7.6 or >> whether they are truly regressions introduced since then? > > Find attached the test-suite.log files from > - the 2.7.6 release, > - a recent snapshot, built with current gnulib [1]. > > Summary: > 2.7.6 current comment > > concat-git-diff PASS FAIL regression > preserve-mode-and-timestamp FAIL FAIL old failure > remember-backup-files FAIL FAIL old failure > unmodified-files FAIL SKIP > 910fecf695e76c7b45a69cb3630ca2d2a3b86121 > > The preserve-mode-and-timestamp failure is probably a consequence > of this Haiku bug: [2]. > > Bruno > > [1] https://github.com/gnu-patch/ci-check/actions/runs/13109741909 > [2] https://dev.haiku-os.org/ticket/19213
Thanks for the confirmation. This looked easy enough to test I guess, so I bit the bullet and installed a Haiku virtual machine, booted into it and figured out how to get a copy of patch.git (and gnulib submodule) to play with. Bisected, and landed on: 043355371a76de8ea7d06f79a69fde905af7cc45 is the first bad commit commit 043355371a76de8ea7d06f79a69fde905af7cc45 Author: Paul Eggert <[email protected]> AuthorDate: Fri Sep 6 22:32:54 2024 Commit: Paul Eggert <[email protected]> CommitDate: Mon Sep 16 01:50:38 2024 X == -1 → X < 0 * src/inp.c (get_input_file, plan_b, ifetch): * src/patch.c (main, get_some_switches, open_outfile) (init_reject, output_file_now): * src/pch.c (open_patch_file, there_is_another_patch) (another_hunk, do_ed_script): * src/safe.c (read_symlink, traverse_another_path): * src/util.c (move_file): Prefer X < 0 to X == -1 when either comparison will do. This lets us focus better on oddball cases like uid_t and time_t when converted from -1. src/inp.c | 6 +++--- src/patch.c | 16 +++++++--------- src/pch.c | 35 +++++++++++++++++------------------ src/safe.c | 8 ++++---- src/util.c | 2 +- 5 files changed, 32 insertions(+), 35 deletions(-) Paul, can you take a look at this? -- Eli Schwartz
OpenPGP_signature.asc
Description: OpenPGP digital signature
