I wrote:
> The only remaining test failure is preserve-mode-and-timestamp,
> for which we have an explanation.

Here's a proposed patch to mark this test as an expected failure,
so that it does not need to be reported in the future.

Before applying the patch, you need to bump the 'gnulib' submodule
to latest. (I added the OS_IS_HAIKU conditional just a few minutes ago.)

With this patch, "make check" passes on Haiku.

Bruno

>From d9e634c5afd20239adece681874e943ee8cc85d5 Mon Sep 17 00:00:00 2001
From: Bruno Haible <[email protected]>
Date: Wed, 5 Feb 2025 22:14:24 +0100
Subject: [PATCH] Declare an expected test failure on Haiku.

* bootstrap.conf (gnulib_modules): Add test-xfail.
* tests/preserve-mode-and-timestamp: Add a comment regarding Haiku.
* tests/Makefile.am (XFAIL_TESTS): On Haiku, add preserve-mode-and-timestamp.
---
 bootstrap.conf                    | 1 +
 tests/Makefile.am                 | 4 ++++
 tests/preserve-mode-and-timestamp | 3 +++
 3 files changed, 8 insertions(+)

diff --git a/bootstrap.conf b/bootstrap.conf
index 88ea1e0..5f914e8 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -83,6 +83,7 @@ stpcpy
 symlinkat
 sys_stat-h
 tempname
+test-xfail
 unistd-h
 unlinkat
 update-copyright
diff --git a/tests/Makefile.am b/tests/Makefile.am
index f4227de..43ddf66 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -67,6 +67,10 @@ TESTS = \
 XFAIL_TESTS = \
 	dash-o-append \
 	context-format
+if OS_IS_HAIKU
+XFAIL_TESTS += \
+	preserve-mode-and-timestamp
+endif
 
 EXTRA_DIST = \
 	$(TESTS) \
diff --git a/tests/preserve-mode-and-timestamp b/tests/preserve-mode-and-timestamp
index 47afbb2..5aa6836 100644
--- a/tests/preserve-mode-and-timestamp
+++ b/tests/preserve-mode-and-timestamp
@@ -6,6 +6,9 @@
 
 . $srcdir/test-lib.sh
 
+# Note: This test fails on Haiku. This is normal; it is caused by
+# Haiku bug <https://dev.haiku-os.org/ticket/19213>.
+
 require cat
 require sed
 require chmod
-- 
2.43.0

  • Re: patch-2.7.... Eli Schwartz
    • Re: patch... Bug reports, suggestions, general discussion for GNU patch.
      • Re: p... Eli Schwartz
        • R... Bug reports, suggestions, general discussion for GNU patch.
          • ... Eli Schwartz
            • ... Bug reports, suggestions, general discussion for GNU patch.
          • ... Bug reports, suggestions, general discussion for GNU patch.
          • ... Paul Eggert
            • ... Andreas Grünbacher
            • ... Bug reports, suggestions, general discussion for GNU patch.

Reply via email to