I just tried to build sh-utils 2.0 and 2.0f on a DECstation 5000 running
Ultrix V4.3 and ran into a couple of problems:

* lib/readutmp.c didn't compile since <sys/types.h> needs to be included
  before <sys/stat.h> for various type definitions.  This is included in
  the patch below.

* With this fix, pinky and who failed to link with strdup undefined.  It's
  used in lib/canon-host.c, but no replacement is provided if it's
  missing.  sh-utils 2.0f has a replacement, so the problem is avoided
  here. 

* sh-utils 2.0f README-alpha should probably use the new bug reporting
  address [EMAIL PROTECTED] instead of the old [EMAIL PROTECTED]?

* Running 2.0f configure with the native /bin/sh gives a warning:

/bin/sh: �: not found
WARNING: `:' is needed, and you do not seem to have it handy on your
         system.  You might have modified some files without having the
         proper tools for further handling them.  Check the `README' file,
         it often tells you about the needed prerequirements for installing
         this package.  You may also peek at any GNU archive site, in case
         some other package would contain this missing `:' program.
configure: warning: `missing' script is too old or missing

  If I rerun configure with CONFIG_SHELL=/bin/sh5 in the environment, it
  works without problems.

* As Bj�rn Fischer has reported before for Digital UNIX V4.0, many date
  tests fail if TZ is set to UTC, but pass with :UTC.  E.g.,

LANG=C TZ=UTC ../../src/date -d '1997-01-19 08:17:48 +0' +'%c'

  yields

Sun Jan 19 09:17:48 1997

  while

LANG=C TZ=:UTC ../../src/date -d '1997-01-19 08:17:48 +0' +'%c'

  gives the expected

Sun Jan 19 08:17:48 1997

  When I made this change to tests/date/Test.pm, running make in a build
  directory (i.e. a VPATH build) failed since perl couldn't find that file
  in $(srcdir).  The patch below to tests/Makefile.am.in fixes this.

* There's one further test failure in seq:

-: test eq-wid-2: stdout mismatch, comparing eq-wid-2.1 and eq-wid-2.O

  Running this test (seq -w -.1 .1 .1) manually gives

-0.1
0.0
0.1

  instead of the expected

-0.1
00.0
00.1

  I haven't investigated further.

Regards.

        Rainer

-----------------------------------------------------------------------------
Rainer Orth, Faculty of Technology, Bielefeld University

Email: [EMAIL PROTECTED]



Wed Mar  1 01:09:33 2000  Rainer Orth  <[EMAIL PROTECTED]>

        * tests/Makefile.am.in: Invoke perl with -I$(srcdir) for VPATH
        builds.

        * tests/date/Test.pm ($Test::env_default): Set TZ to :UTC to avoid
        test failures on Compaq Tru64 Unix and Ultrix.

        * lib/readutmp.c: Include <sys/types.h>, Ultrix V4.3 <sys/stat.h>
        needs it for dev_t.

===================================================================
RCS file: lib/RCS/readutmp.c,v
retrieving revision 1.1
diff -up -r1.1 lib/readutmp.c
--- lib/readutmp.c      2000/01/31 10:22:35     1.1
+++ lib/readutmp.c      2000/03/01 00:20:55
@@ -21,6 +21,7 @@
 
 #include <stdio.h>
 
+#include <sys/types.h>
 #include <sys/stat.h>
 #if defined(STDC_HEADERS) || defined(HAVE_STRING_H)
 # include <string.h>
===================================================================
RCS file: tests/RCS/Makefile.am.in,v
retrieving revision 1.1
diff -up -r1.1 tests/Makefile.am.in
--- tests/Makefile.am.in        1998/06/18 15:20:54     1.1
+++ tests/Makefile.am.in        2000/03/01 19:16:07
@@ -13,7 +13,7 @@ TESTS = $x-tests
 
 mk_script = $(srcdir)/../mk-script
 $(srcdir)/$x-tests: $(mk_script) Test.pm
-       $(PERL) -I. -w -- $(mk_script) ../../src/$x > [email protected]
+       $(PERL) -I. -I$(srcdir) -w -- $(mk_script) ../../src/$x > [email protected]
        mv [email protected] $@
        chmod 755 $@
 
@@ -27,6 +27,6 @@ Makefile.am: ../Makefile.am.in Test.pm $
        sed -n '1,/^##test-files-begin/p' $< > $@t
        tool=`echo $(subdir)|sed 's/^tests.//;s/-test//'`; \
          echo "x = $$tool" >> $@t
-       $(PERL) -I. -w -- $(mk_script) --list >> $@t
+       $(PERL) -I. -I$(srcdir) -w -- $(mk_script) --list >> $@t
        sed -n '/^##test-files-end/,$$p' $< >> $@t
        mv $@t $@
===================================================================
RCS file: tests/date/RCS/Test.pm,v
retrieving revision 1.1
diff -up -r1.1 tests/date/Test.pm
--- tests/date/Test.pm  1999/12/22 11:01:04     1.1
+++ tests/date/Test.pm  2000/03/01 18:49:25
@@ -5,8 +5,8 @@ use strict;
 
 # For each test...
 # Export LANG=C so that the locale-dependent strings match.
-# Export TZ=UTC so that zone-dependent strings match.
-$Test::env_default = ['LANG=C TZ=UTC'];
+# Export TZ=:UTC so that zone-dependent strings match.
+$Test::env_default = ['LANG=C TZ=:UTC'];
 
 sub test_vector
 {

Reply via email to