Richard Stallman wrote:
> This is an issue even for short and trivial patches. For example, for
> this one:
>
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f8b4e87d5d4f57954b50677add76ce5136211dc1
> I guess that it took me a couple of minutes to write and test the patch,
> and about the same time to write the ChangeLog entry.
I fetched that page and did not see anything like a ChangeLog entry.
I cannot fetch the page now, since Savannah is broken (it says "502 Bad
Gateway").
Unless it is this:
Fix copyright years by hand
These are dates that admin/update-copyright did not update, or updated
incorrectly.
That's not the patch I was referring to. I'm attaching a copy of the patch I was
talking about. It was generated by the shell command "git format-patch
f8b4e87d5d4f57954b50677add76ce5136211dc1^!".
>From f8b4e87d5d4f57954b50677add76ce5136211dc1 Mon Sep 17 00:00:00 2001
From: Paul Eggert <[email protected]>
Date: Tue, 2 Jan 2018 22:38:01 -0800
Subject: [PATCH] Fix .gdbinit to work with Lisp_Word
Problem reported by Stefan Monnier (Bug#29957).
* src/.gdbinit (xgetptr, xgetint, xgettype):
Cast Lisp_Word value to EMACS_INT, since it might be a pointer now.
---
src/.gdbinit | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/.gdbinit b/src/.gdbinit
index de35ef1..a5411e6 100644
--- a/src/.gdbinit
+++ b/src/.gdbinit
@@ -49,7 +49,7 @@ define xgetptr
else
set $bugfix = $arg0
end
- set $ptr = $bugfix & VALMASK
+ set $ptr = (EMACS_INT) $bugfix & VALMASK
end
define xgetint
@@ -58,7 +58,7 @@ define xgetint
else
set $bugfix = $arg0
end
- set $int = $bugfix << (USE_LSB_TAG ? 0 : INTTYPEBITS) >> INTTYPEBITS
+ set $int = (EMACS_INT) $bugfix << (USE_LSB_TAG ? 0 : INTTYPEBITS) >> INTTYPEBITS
end
define xgettype
@@ -67,7 +67,7 @@ define xgettype
else
set $bugfix = $arg0
end
- set $type = (enum Lisp_Type) (USE_LSB_TAG ? $bugfix & (1 << GCTYPEBITS) - 1 : (EMACS_UINT) $bugfix >> VALBITS)
+ set $type = (enum Lisp_Type) (USE_LSB_TAG ? (EMACS_INT) $bugfix & (1 << GCTYPEBITS) - 1 : (EMACS_UINT) $bugfix >> VALBITS)
end
define xgetsym
--
2.7.4
