Mike Frysinger <[email protected]> writes: > On Thursday 24 May 2012 16:09:31 Giuseppe Scrivano wrote:
>> Then we should check, trough the configure script, that the zlib version >> used supports this new type. I don't think there are problems to force >> the zlib version >= the last one supporting the new type, I am not >> particularly worried about not supporting old versions of the libraries. > > that doesn't make sense here. the zlib API has always defined gzFile, and > has > operated on that. it has never utilized gzFile*. the fact that it didn't > warn in the past was due to the zlib API not containing code that'd > implicitly > check it, and the reason it doesn't fail at runtime is that gzFile internally > is basically a pointer. so a pointer to a struct is the same size as a > pointer to a pointer, thus the ABI/generated code is unchanged. Ok, I have checked that and it is safe to do this change, the rest of the warc.c file assumes the type is a pointer. Old versions defined gzFile as void *, instead new versions use an opaque type as 'typedef struct gzFile_s *gzFile;' Can you please amend the ChangeLog entry? Thanks, Giuseppe
