On Wednesday 01 October 2014 22:04:53 Giuseppe Scrivano wrote: > Tim Ruehsen <[email protected]> writes: > > While there might be more than one problem, at least one is the naming of > > the tests. The name given to HTTPServer->new() should always be unique > > because is is taken as a temporary working directory. Some tests have > > wrong name (copy&paste I guess) and thus randomly fail when running in > > parallel ! > > > > Here is a patch to fix this. > > > > Tim > > > > From 4a5fd2244545c2c05f40cb7a2dfba7866919d047 Mon Sep 17 00:00:00 2001 > > From: =?UTF-8?q?Tim=20R=C3=BChsen?= <[email protected]> > > Date: Wed, 1 Oct 2014 16:42:04 +0200 > > Subject: [PATCH] fixed test suite race conditions due to double usage of > > names > > > > --- > > > > tests/ChangeLog | 9 +++++++++ > > tests/Test--post-file.px | 2 +- > > tests/Test-N-no-info.px | 2 +- > > tests/Test-N-smaller.px | 2 +- > > tests/Test-c-shorter.px | 2 +- > > tests/Test-proxied-https-auth.px | 2 +- > > tests/Test-proxy-auth-basic.px | 2 +- > > 7 files changed, 15 insertions(+), 6 deletions(-) > > the patch looks correct, I am going to push it soon.
I am sorry to say there is another little problem with dist-check. run-px is still mentioned in tests/Makefile.am but already removed. Here is a small patch to fix this. Tim
>From 7a072b76e0af26b723330beb9a73be620bce4faf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20R=C3=BChsen?= <[email protected]> Date: Thu, 2 Oct 2014 09:28:47 +0200 Subject: [PATCH] remove run-px from tests/makefile.am --- tests/ChangeLog | 4 ++++ tests/Makefile.am | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/ChangeLog b/tests/ChangeLog index 0f1e542..45293eb 100644 --- a/tests/ChangeLog +++ b/tests/ChangeLog @@ -1,5 +1,9 @@ 2014-10-01 Tim Ruehsen <[email protected]> + * tests/Makefile.am: remove run-px, fixing dist-check + +2014-10-01 Tim Ruehsen <[email protected]> + * Test--post-file.px: name => "Test--post-file", fixing race condition. * Test-N-no-info.px: name => "Test-N-no-info", fixing race diff --git a/tests/Makefile.am b/tests/Makefile.am index 76f6f44..1248036 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -131,7 +131,7 @@ PX_TESTS = \ EXTRA_DIST = FTPServer.pm FTPTest.pm HTTPServer.pm HTTPTest.pm \ WgetTests.pm WgetFeature.pm WgetFeature.cfg $(PX_TESTS) \ - run-px certs + certs check_PROGRAMS = unit-tests unit_tests_SOURCES = -- 2.1.1
