On 10/01, Tim Rühsen wrote:
On Tuesday 30 September 2014 21:52:01 Darshit Shah wrote:I was just going through your patch. Could you please add the *.trs and *.log entries to the .gitignore file? They would be listed under the Wildcards.Done.About the fix for Test-proxied-https.px, I came across the following guideline in the Automake Tests manual: > Test programs that need data files should look for them in srcdir (which > is > both a make variable and an environment variable made available to the > tests), so that they work when building in a separate directory (see > Build Directories in The Autoconf Manual), and in particular for the > distcheck rule (see Checking the Distribution).Done, using srcdir seems cleaner.I've been implementing a fix for testenv/ using abs_top_srcdir, but it seems we should be using $srcdir, maybe you can fix that? Also, the patch was generated against a slightly older git history, which is why it doesn't apply cleanly and fails on ChangeLog. Maybe you could run a git pull and then rebase your patch off the latest commit?Done.
--- end quoted text --- Hi Tim,I saw the diff of the patch and it looked good. But, running it, I'm experiencing a lot of issues.
Test-proxied-https.px runs perfectly when executed directly but will *always* fail when executed through make check. The print statement at line 18 in Test-proxied-https.px complains about an uninitialized variable when the test is executed directly.
The Test-iri* tests all fail, *always", when either executed directly or when make check is called from the tests/ directory. They execute successfully when make check is invoked from the root directory of the repository. Hence, I believe the issue lies in the test suite and not in Wget.
I've attached the files:1. Test-proxied-https.px.log.direct: This was generated by directly executing the test. The test passes without issue.
2. Test-proxied-https-auth.log: Autogenerated by make check. The test fails.3. Test-iri.log: Generated by make check when executed from the tests/ dir. The output is exactly the same as when attempting to directly execute the test. 4. Tests-iri.px.log.pass: This was generated when Test-iri.px is executed by make check and the command was run from the project's root dir. It shows the test was successful.
The Test-iri* files fail when executed from the tests/ directory even without the patch, but the issue with Test-proxied-https is definitely a regression
-- Thanking You, Darshit Shah
Use of uninitialized value in print at ./Test-proxied-https-auth.px line 18. srcdir= --2014-10-01 15:42:42-- https://no.such.domain/needs-auth.txt Resolving localhost (localhost)... ::1, 127.0.0.1 Connecting to localhost (localhost)|::1|:44833... failed: Connection refused. Connecting to localhost (localhost)|127.0.0.1|:44833... connected. WARNING: cannot verify no.such.domain's certificate, issued by ‘/C=US/ST=California/L=Santa Claa/O=Internet Widgits Pty Ltd/CN=Micah Cowan/[email protected]’: Self-signed certificate encountered. WARNING: certificate common name ‘Micah Cowan’ doesn't match requested host name ‘no.such.domain’. Proxy request sent, awaiting response... 401 Unauthorized Reusing existing connection to no.such.domain:443. Proxy request sent, awaiting response... No data received. Retrying. --2014-10-01 15:42:43-- (try: 2) https://no.such.domain/needs-auth.txt Connecting to localhost (localhost)|127.0.0.1|:44833... connected. WARNING: cannot verify no.such.domain's certificate, issued by ‘/C=US/ST=California/L=Santa Claa/O=Internet Widgits Pty Ltd/CN=Micah Cowan/[email protected]’: Self-signed certificate encountered. WARNING: certificate common name ‘Micah Cowan’ doesn't match requested host name ‘no.such.domain’. Proxy request sent, awaiting response... 200 OK Length: unspecified [text/plain] Saving to: ‘needs-auth.txt’ 0K HTTP/1.0 401 Unauthorized Connection: close WWW-Authenticate: Basic realm="gondor" ===== HTTP/1.0 200 OK Connection: close Content-Type: text/plain foobarbaz ===== 1.75M=0s 2014-10-01 15:42:43 (1.75 MB/s) - ‘needs-auth.txt’ saved [10]
srcdir=. --2014-10-01 15:40:40-- https://no.such.domain/needs-auth.txt Resolving localhost (localhost)... ::1, 127.0.0.1 Connecting to localhost (localhost)|::1|:33436... failed: Connection refused. Connecting to localhost (localhost)|127.0.0.1|:33436... connected. WARNING: cannot verify no.such.domain's certificate, issued by '/C=US/ST=California/L=Santa Claa/O=Internet Widgits Pty Ltd/CN=Micah Cowan/[email protected]': Self-signed certificate encountered. WARNING: certificate common name 'Micah Cowan' doesn't match requested host name 'no.such.domain'. Proxy request sent, awaiting response... 401 Unauthorized Reusing existing connection to no.such.domain:443. Proxy request sent, awaiting response... No data received. Retrying. --2014-10-01 15:40:41-- (try: 2) https://no.such.domain/needs-auth.txt Got code: 256
Running test Test-iri Calling ../src/wget --iri --trust-server-names --restrict-file-names=nocontrol -nH -r http://localhost:46643/ --2014-10-01 15:39:13-- http://localhost:46643/ Resolving localhost (localhost)... ::1, 127.0.0.1 Connecting to localhost (localhost)|::1|:46643... failed: Connection refused. Connecting to localhost (localhost)|127.0.0.1|:46643... connected. HTTP request sent, awaiting response... 200 Ok Length: 279 [text/html] Saving to: ‘index.html’ 0K 100% 27.0M=0s 2014-10-01 15:39:13 (27.0 MB/s) - ‘index.html’ saved [279/279] Loading robots.txt; please ignore errors. --2014-10-01 15:39:13-- http://localhost:46643/robots.txt Reusing existing connection to localhost:46643. HTTP request sent, awaiting response... 200 Ok Length: unspecified [text/plain] Saving to: ‘robots.txt’ 0K 0.00 =0s 2014-10-01 15:39:13 (0.00 B/s) - ‘robots.txt’ saved [0] --2014-10-01 15:39:13-- http://localhost:46643/p1_fran%E7ais.html Connecting to localhost (localhost)|127.0.0.1|:46643... connected. HTTP request sent, awaiting response... 200 Ok Length: 283 [text/html] Saving to: ‘p1_fran\347ais.html’ 0K 100% 28.6M=0s 2014-10-01 15:39:13 (28.6 MB/s) - ‘p1_fran\347ais.html’ saved [283/283] --2014-10-01 15:39:13-- http://localhost:46643/p3_%A4%A4%A4.html Reusing existing connection to localhost:46643. HTTP request sent, awaiting response... 200 Ok Length: 190 [text/plain] Saving to: ‘p3_\244\244\244.html’ 0K 100% 7.05M=0s 2014-10-01 15:39:13 (7.05 MB/s) - ‘p3_\244\244\244.html’ saved [190/190] --2014-10-01 15:39:13-- http://localhost:46643/p2_%E9%E9n.html Reusing existing connection to localhost:46643. HTTP request sent, awaiting response... 400 Bad Request 2014-10-01 15:39:13 ERROR 400: Bad Request. FINISHED --2014-10-01 15:39:13-- Total wall clock time: 0.06s Downloaded: 4 files, 752 in 0s (15.9 MB/s) Test failed: wrong code returned (was: 8, expected: 0)
Running test Test-iri Calling ../src/wget --iri --trust-server-names --restrict-file-names=nocontrol -nH -r http://localhost:57934/ --2014-10-01 15:37:17-- http://localhost:57934/ Resolving localhost (localhost)... ::1, 127.0.0.1 Connecting to localhost (localhost)|::1|:57934... failed: Connection refused. Connecting to localhost (localhost)|127.0.0.1|:57934... connected. HTTP request sent, awaiting response... 200 Ok Length: 279 [text/html] Saving to: 'index.html' 0K 100% 33.1M=0s 2014-10-01 15:37:17 (33.1 MB/s) - 'index.html' saved [279/279] Incomplete or invalid multibyte sequence encountered Incomplete or invalid multibyte sequence encountered Loading robots.txt; please ignore errors. --2014-10-01 15:37:17-- http://localhost:57934/robots.txt Reusing existing connection to localhost:57934. HTTP request sent, awaiting response... 200 Ok Length: unspecified [text/plain] Saving to: 'robots.txt' 0K 0.00 =0s 2014-10-01 15:37:17 (0.00 B/s) - 'robots.txt' saved [0] --2014-10-01 15:37:17-- http://localhost:57934/p1_fran%C3%A7ais.html Connecting to localhost (localhost)|127.0.0.1|:57934... connected. HTTP request sent, awaiting response... 404 File not found 2014-10-01 15:37:17 ERROR 404: File not found. --2014-10-01 15:37:17-- http://localhost:57934/p1_fran%E7ais.html Reusing existing connection to localhost:57934. HTTP request sent, awaiting response... 200 Ok Length: 283 [text/html] Saving to: 'p1_fran\347ais.html' 0K 100% 16.7M=0s 2014-10-01 15:37:17 (16.7 MB/s) - 'p1_fran\347ais.html' saved [283/283] Incomplete or invalid multibyte sequence encountered --2014-10-01 15:37:17-- http://localhost:57934/p3_%E2%82%AC%E2%82%AC%E2%82%AC.html Reusing existing connection to localhost:57934. HTTP request sent, awaiting response... 200 Ok Length: 190 [text/plain] Saving to: 'p3_\342\202\254\342\202\254\342\202\254.html' 0K 100% 10.3M=0s 2014-10-01 15:37:17 (10.3 MB/s) - 'p3_\342\202\254\342\202\254\342\202\254.html' saved [190/190] --2014-10-01 15:37:17-- http://localhost:57934/p2_%C3%A9%C3%A9n.html Reusing existing connection to localhost:57934. HTTP request sent, awaiting response... 200 Ok Length: 404 [text/html] Saving to: 'p2_\303\251\303\251n.html' 0K 100% 42.8M=0s 2014-10-01 15:37:17 (42.8 MB/s) - 'p2_\303\251\303\251n.html' saved [404/404] Incomplete or invalid multibyte sequence encountered --2014-10-01 15:37:17-- http://localhost:57934/p4_m%C3%A9%C3%A9r.html Reusing existing connection to localhost:57934. HTTP request sent, awaiting response... 200 Ok Length: 121 [text/plain] Saving to: 'p4_m\303\251\303\251r.html' 0K 100% 15.3M=0s 2014-10-01 15:37:17 (15.3 MB/s) - 'p4_m\303\251\303\251r.html' saved [121/121] FINISHED --2014-10-01 15:37:17-- Total wall clock time: 0.2s Downloaded: 6 files, 1.2K in 0s (20.9 MB/s) Test successful.
pgp2AfJgTRocY.pgp
Description: PGP signature
