On Fri, Dec 12, 2014 at 9:45 PM, Tim Ruehsen <[email protected]> wrote: > On Thursday 11 December 2014 11:51:27 Charles Diza wrote: >> On Thu, Dec 11, 2014 at 4:39 AM, Tim Ruehsen <[email protected]> wrote: >> > On Wednesday 10 December 2014 12:02:32 Charles Diza wrote: >> > > Wget 1.16.1 has broken detection of non-built-in openssl on MacOSX. >> > > >> > > Openssl comes with MacOSX but it's deprecated by Apple and it's an old >> > > version. For this reason, many MacOSX users custom install a newer >> > > openssl and put it in /usr/local/ssl (which, IIRC, is the default >> > > location for custom openssl installs). >> > > >> > > Up through wget 1.16, the following configure flags sufficed to make >> > > wget's configure script recognize this custom openssl and *use* it: >> > > >> > > ./configure --with-ssl=openssl --with-libssl-prefix=/usr/local/ssl >> > > >> > > But on wget 1.16.1, those same flags have no effect, and wget is built >> > > against the Mac system openssl in /usr/lib, which is old and deprecated. >> > > Something in the configure script must have changed. >> > > >> > > I hope that this is either repaired, or that the README/INSTALL are >> > > amended to include special instructions on how to force wget to pick up >> > > a custom openssl on MacOSX. >> > > >> > > I'm no programmer, but I have a hunch that the same batch of pkg-config >> > > related changes (2014-11-01 in the ChangeLog) that broke pcre handling >> > > on MacOSX (See earlier thread) have broken openssl detection. >> > > >> > > I do have pkg-config on my system, in /usr/local. I have found that >> > > whether or not I remove pkg-config from my system, I can't get openssl >> > > in /usr/local/ssl to get picked up and used to link with" lines. >> > >> > Please try the following: >> > - make a copy of openssl.pc (the pkg-config file of OpenSSL) into your >> > wget >> > directory. >> > - change the first line 'prefix=...' to 'prefix=/usr/local/ssl' >> > - try 'PKG_CONFIG_PATH="." ./configure --with-ssl=openssl' >> > >> > Later, you may keep your openssl.pc in /usr/local/pkgconfig/, so you can >> > easily find and use it with other projects. >> > >> > Please report if this (or similar) works for you. >> > Of course that has to documented... we simply didn't fall over this issue >> > so >> > far. >> >> OK, that worked, thanks; indeed, all I had to do was >> 'PKG_CONFIG_PATH=/usr/local/ssl/lib/pkgconfig ./configure blah blah'. Easy >> enough. (That's the default location for a built-from-source openssl; is >> openssl not putting its .pc file where it should?) > > I guess yes, if you 'make install' your local copy of OpenSSL. > >> But that's only half the battle, because that only covers the case where >> the Mac user has pkg-config installed. Pkg-config doesn't come with OSX or >> the Apple dev tools. Up through wget 1.16, the pkgconfigless Mac user >> could rely on --with-libssl-prefix to point wget to the right place. > > Please see the output of ./configure --help. > If you don't have pkg-config installed, please try the following > Add "-I/usr/local/ssl/include" to your CFLAGS > and add "-L/usr/local/ssl/lib" to your LDFLAGS. > export both and ./configure. >
But shouldn't openssl detection work without pkg-config too? We did retain the old detection code as a fallback mechanism in case pkg-config didn't work. Given the number of complains we've received about this, I think its time to look back into configure.ac and figure out where that detection is going wrong. Users shouldn't have to do all these shenanigans to get Wget to compile. -- Thanking You, Darshit Shah
