Am Montag, 6. April 2015, 22:26:27 schrieb Tim Rühsen: > Hi Hubert, > > Am Montag, 6. April 2015, 12:57:18 schrieb Hubert Tarasiuk: > > Hello devs, > > > > Also, IMHO it is worth to add a suppression file for valgrind tests in > > wget. Otherwise, the tests do not pass. (Apart from the bug mentioned > > above, there is a Valgrind's false positive at `idna_to_ascii_4z` in > > `libidn.so`.) And since the first part (`tests`) fails, `make check` > > does not even make it to the second part (`testenv`). (Which is probably > > another bug, not a feature :D.) > > The problem is, that I do not see a simple way to add it in one place; > > as Valgrind invocation is handled separately in both `testenv` and > > `tests`. However, the problem appears only in `tests` currently, > > therefore maybe it could be added just there. > > I am attaching my workaround for the problem (Valgrind's suppression > > file and a patch to WgetTests.pm) - it could be probably done in a more > > elegant way. > > Good fix (also the idna issue that Ángel answered to) ! > > Valgrind suppressions are a bit compiler/architecture/distribution > dependent. Maybe you could you add a comment into the suppression file with > these infos. As a quick reference and explanation. > > And yes, if you find a proper way to execute the 'testenv' part no matter if > 'tests' fails or not, a patch would be welcome. It always annoyed me, but > not enough to put work into it :-(
Sorry, one point I missed: Please put the suppression file into EXTRA_DIST variable in tests/Makefile.am. Else it won't go into the tarball (make dist). > > Regards, Tim
signature.asc
Description: This is a digitally signed message part.
