Sorry, in main.c it should have been if (filename && hsts_store->changed)
On 24/05/16 11:23, Ander Juaristi wrote: > Hi Tim, > > On 24/05/16 10:24, Tim Ruehsen wrote: >> Hi Ander, >> >> IMO, another possibility is to add a flag to 'struct hsts_store' that >> indicates any change made. hsts_store_save() could be skipped if that flag >> is >> not set. >> >> At the same time the debug info has to be moved from main.c/save_hsts() to >> hsts.c/hsts_store_save() OR hsts.c needs another function to return the >> value >> of the flag, so that save_hsts() could check it. >> > > You mean something like the attached? > >> WDYT ? > > That could be an option. But I'm not sure we can skip the call to > hsts_store_save at all, because doing so would also mean not updating > the in-memory HSTS database, which might have been modified by other > wget processes. > > We could also test whether there have been such changes (within > hsts_store_save), and then call hsts_store_dump only if affirmative. But > again, I don't think it pays off for the sole reason of removing a debug > message. > >> >> Tim >>
