Thanks, pushed ! Tim
On Wednesday 25 May 2016 22:26:33 Ander Juaristi wrote: > Hi Tim, > > On 24/05/16 14:49, Tim Ruehsen wrote: > > I meant e.g. in hsts_match(), you eventually remove an expired entry, but > > you do not set store->changed. Thus on exit, the database wouldn't be > > updated. I think it is good to keep the database as small as possible - > > following invocations of wget have less to read. > > True. I could not reproduce the behavior you describe, but I see the > 'changed' field is not being updated in hsts_match(). I knew I was > forgetting something! > > Please find a new patch attached, and tell me if there's still something > left. > > > Sounds good, thanks for explaining. > > My thought was to update the DB every time we get a STS header, since > > max_age is relative to the current time. But your approach is much more > > elegant in respect to the number of writes (disk&cpu usage). > > Actually, I blindly followed the RFC. > > But yes, I guess that was one of the reasons the RFC authors did it that > way. > > > Tim > > Best regards, > > - AJ
signature.asc
Description: This is a digitally signed message part.
